Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 60 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,61 @@
class Distance:
# Write your code here
pass

def __init__(self, km: int) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

km can also be float here

self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: int) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import annotation from future to give annotation for classes without quotes

other can also be float or Disntance types here. Check this mistake in all methods

if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)
return NotImplemented

def __iadd__(self, other: int) -> "Distance":
if isinstance(other, Distance):
self.km += other.km
elif isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: int) -> "Distance":
if isinstance(other, (int, float)):
return Distance(self.km * other)
return NotImplemented

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other can not be of type Distance in this method, because if you multiply km * km you get square km


def __truediv__(self, other: int) -> "Distance":
if isinstance(other, (int, float)):
return Distance(round(self.km / other, 2))
return NotImplemented

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other can not be of type Distance in this method


def __lt__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other
return NotImplemented

def __gt__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km > other.km
elif isinstance(other, (int, float)):
return self.km > other
return NotImplemented

def __eq__(self, other: int) -> bool:
if isinstance(other, Distance):
return self.km == other.km
elif isinstance(other, (int, float)):
return self.km == other
return NotImplemented

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect only int, float, or Distance types here. That is, you need to do only 1 check, if it is not Distance, it will be float or int


def __le__(self, other: int) -> bool:
return self < other or self == other

def __ge__(self, other: int) -> bool:
return self > other or self == other
Loading