Solution #1457
Open
Solution #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levseenko
approved these changes
Oct 3, 2024
AnyoneClown
suggested changes
Oct 3, 2024
app/main.py
Outdated
| # Write your code here | ||
| pass | ||
|
|
||
| def __init__(self, km: int) -> None: |
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: int) -> "Distance": |
There was a problem hiding this comment.
Import annotation from future to give annotation for classes without quotes
other can also be float or Disntance types here. Check this mistake in all methods
app/main.py
Outdated
Comment on lines
25
to
29
|
|
||
| def __mul__(self, other: int) -> "Distance": | ||
| if isinstance(other, (int, float)): | ||
| return Distance(self.km * other) | ||
| return NotImplemented |
There was a problem hiding this comment.
other can not be of type Distance in this method, because if you multiply km * km you get square km
app/main.py
Outdated
Comment on lines
31
to
34
| def __truediv__(self, other: int) -> "Distance": | ||
| if isinstance(other, (int, float)): | ||
| return Distance(round(self.km / other, 2)) | ||
| return NotImplemented |
There was a problem hiding this comment.
other can not be of type Distance in this method
app/main.py
Outdated
Comment on lines
36
to
55
| def __lt__(self, other: int) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km < other | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: int) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km > other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km > other | ||
| return NotImplemented | ||
|
|
||
| def __eq__(self, other: int) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km == other.km | ||
| elif isinstance(other, (int, float)): | ||
| return self.km == other | ||
| return NotImplemented |
There was a problem hiding this comment.
We expect only int, float, or Distance types here. That is, you need to do only 1 check, if it is not Distance, it will be float or int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.