Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$setValidity should not be used with a blank error key. #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

$setValidity should not be used with a blank error key. #16

wants to merge 3 commits into from

Commits on Apr 21, 2015

  1. Fixes breaking change for Angular 1.2 users. 

    Validation now checks for the existence of ctrl.$validators, defaulting to the Angular 1.2 compatible ctrl.$parsers pipeline when necessary. Validation logic reverted to state as of version 0.0.4.
    @idpaterson
    idpaterson committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    7945157 View commit details
    Browse the repository at this point in the history

  2. $setValidity should not be used with a blank error key. 

    This can unintentionally make the field required; if the text field is cleared while displaying an invalid phone number, the '' error key will remain invalid.
    @idpaterson
    idpaterson committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    0ac381c View commit details
    Browse the repository at this point in the history

  3. Avoid inconsistent validity due to deleting from $error 

    We noticed that in some cases after clearing the field to type a new number the ng-invalid class stuck around despite ng-valid-international-phone-number. This fixes what may be due to an inconsistency in ngModelController after deleting the key from $error.
    @idpaterson
    idpaterson committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    5ea6581 View commit details
    Browse the repository at this point in the history