$setValidity should not be used with a blank error key.

[idpaterson]

This can unintentionally make the field required; if the text field is cleared while displaying an invalid phone number, the '' error key will remain invalid.

To test:

1. Begin with a non-required international-phone-number field
2. Type an invalid phone number such as +1 555 555 5555
3. Delete the phone number leaving a blank field (or just the + prompt)

The field will have a validation error, $error: {"international-phone-number":false,"":true} because the blank validation key is still invalid. I believe that b0a4fea where this blank error key was introduced was attempting to resolve the problem fixed in #15.

[mareczek]

Today I read into the docs regarding this matter. I found out that this is not the best way to do validation checking. Consider this:

ctrl.$validators.internationalPhoneNumber = function(value) {
  return value && element.intlTelInput("isValidNumber");
};

This way it seems like a clean separation between parses (which prepare value for validation checking and eventually writing into model) and validation.

[idpaterson]

It is indeed better to use the new $validators pipeline, but unfortunately that would bump your minimum Angular version from 1.2 to 1.3. Would you consider merging this and then if the $validators approach is desired, add it as a breaking change in a 1.0.0 or 0.1.0 version?

[mareczek]

Yes, no problem. Please submit a pull request, I'll merge it as one of 0.0.*. Then I'll move the solution with $validators to 0.1.0 as you suggested

[idpaterson]

@mareczek since yesterday's 0.0.6 introduces $validators which breaks the module for Angular 1.2 users, I have updated this pull request against the current master so that it will once again allow changes to be merged after your changes latest commits.

I think there was some confusion since this pull request was pending and ready to merge for some time before that change was made and your comment was on the commit within the pull request rather than on the pull request itself.

After these changes, the module checks whether ctrl.$validators is defined to switch between Angular 1.2 compatible and 1.3 compatible validation. It would be a shame to drop Angular 1.2 support for a trivial issue like that. Most importantly, any Angular 1.2 users who upgraded to 0.0.6 would have noticed that the directive was not functioning due to assigning to the undefined ctrl.$validators.

Finally, the change in #15 has been included since #15 would otherwise have merge conflicts. Please consider reviewing other pull requests, then building the distribution scripts with a 0.0.8 tag to fix the Angular 1.2 compatibility issue.