Readme cleanup, final API state #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sheindel
commented
Aug 21, 2023
•
sheindel
commented
- Fixed some issues with backwards compatibility with API surface by better handling defaults for zip options.
- Allow root zip file outputs
- Made API truly no-options capable (fixed no types bug)
- Updated README
- Updated version
|
@charlieforward9 after sleeping on this, and thinking about the version bump, I realized that my API really wasn't fully backwards compatible, so I updated our changes so it is now backwards compatible and an even more minimal startup experience. I also bumped the version, fixed a deprecated bug with the buffers, and allowed for root .zip folder placement (the goal of PR 53). The API change also gets rid of the duplicated default options, which weren't helpful anyways. |
This was referenced Aug 21, 2023
Closed
Closed
Closed
|
@sheindel Looks good! Thanks for doing this. Looks like the last thing to do is publish to npm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.