Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE download fix #50

Closed
wants to merge 8 commits into from
Closed

IE download fix #50

wants to merge 8 commits into from

Conversation

Miroko
Copy link
Member

@Miroko Miroko commented Jun 14, 2017

  • Fixed download on IE by using FileSaver.js instead of setting href. This adds a new dependency but should help to keep different browsers supported in the future as well.
  • Updated jszip to 3.1.3 as Deflate compression error Stuk/jszip#53 has been resolved
    • Changed the compression method to DEFLATE instead of STORE
  • Also modified the index.html to be a test page for this library.
  • Updated readme.

This pr should close these issues: #49, #48, #28

hwbllmnn added a commit to hwbllmnn/shp-write that referenced this pull request Nov 30, 2018
@hwbllmnn
integrate mapbox#50
04d4d91 
Also includes the following:

* adds eslint/editorconfig
* applied eslint formatting for all sources
* some minor fixes discovered through linting
@alexmuro
Copy link

alexmuro commented Apr 9, 2019

This code helped me a ton in chrome to download larger files. Was getting about:blank#blocked with the current download clode.

@sheindel
Copy link
Contributor

Should be resolved thanks to #96 and #100 , will publish soon, thanks!!

@sheindel sheindel closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miroko @alexmuro @sheindel