Release v1.26.0 #145
Merged
Release v1.26.0 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Update ATTCS and at_tracking tests to salobj v4 Add some cosmetics fixes. Fixed passing check to configuration in at_tracking_tcs Unpack dictionary Initial tracking integration test with attcs Fix flake8 violation on attcs.py Added heartbeat check Fix atptg added await unfixed a fix that wasn't a fix unfixed a fix that wasn't a fix fixed problems fixed capitalization issue fault state tests rewrote test to actually be a unit test Added tracking added unit test for slew Add attcs Added athexapod correction check & pneumatics correction check A version of the tracking integration test
* develop: DM-21027: Get ATTCS class and scripts in latest version of standard script.
* develop: Update scripts and tests for ts_xml v4.4. DM-21741: Improvements on attcs class.
* develop: Fix for ATMonochromator.Slit enumeration. Improve Jenkinsfile so it will checkout all dependencies in the appropriate branch.
* develop: Improve close down of latiss mock. (+41 squashed commits) Squashed commits: Fix put event with inexistent force_output argument. Update unit tests. Fix to slew pa so that dispersion is aligned with elevation. Implement fix on slew_pa. Add stop_all task to stop dome and telescope ing of parallacti angle method. print parallactic angle in degrees. Add option to set rotator with respect to the parallactic angle. Make offsets_azel and offset_xy persistent or not. Fix prepare for flat. Fix, prepare for flat. Correct angle between camera and az/el axis when doing xy offset. Fix the way it calculates offset_xy using nasmyth2. Some improvements in the startup procedure. Update offset_radec to use right configuration. Get position of nasmyth 2 when doing the offset instead of the nasmyth 1. Implement offset routines. Make some improvements to startup scripts. Fix slew to target check on atdome trajectory. Implement slew_object. Fix auto setting of shutter open/close. Disable check of atdometrajectory when moving telescope to park position in shutdown. Create internal event for dome in position. Deactivate wait_for_atdome_inposition while issue with the event is fixed. remove await from flush. Fix check_component_state In Shutdown, stop tracking once telescope arrives at park position. Improve monitor dome in position. in stop_tracking get in position before flushing. In stop tracking wait for mount in position = False event. Go back to stop tracking before sending new target. Go back to previous algorithm where no stop tracking is sent. use self.stop_tracking to stop tracking. Stop tracking before sending start tracking. Increase time to wait for telescope to start moving. Add first pass in monitor in position of the telescope Add a sleep of half settle time after slew command is sent to allow the telescope to start moving. pass ack to wait_for_inposition. Implement work around for dome mixing up in position event. Add wait for settle time in slew operation. Add place-holder for offset methods. Add timeout on wait for LFO event from the header service. Fix test_cam_take_image to publish evt_largeFileObjectAvailable after endReadout Fix unit tests for ATTCS class. Add unit test for baseGroup and some fixes for attcs_mock Fix infinity recursion in __getattribute__ Implement changes based on lessons learned after last run. Increase ATDome azimuth tolerance to match that of ATDomeTrajectory. Add debug statements to stop_tracking. Fix open_m1_cover for when cover is already opened. Implement stop tracking task, Some fixes in monitor_position. Some more improvements to ATTCS monitor_position. Fix calculating axes in position in monitor_position Implement some more improvements on ATTCS class. Some general improvements to ATTCS class operations. Implement some improvements in shutdown procedure. Add logging to LATISS class. Wait LFO before returning expose command Improve archiver wait in expose. Add sleep after images is taken. Add a longer wait for the target event before monitoring position. Flush azimuthState before homing. Improve slew activity to catch cases where the dome is already in position. In startup, home the dome and move it to east (az=90 deg) to avoid sun contact before opening the mirror. Increase timeout for atdome.cmd_closeShutter in shutdown procedure. Add BaseScriptTestCase and update the unit tests to use it.
* develop: Update `make_idl_files.py` call in Jenkinsfile. Run Jenkins build against master. Fix headers in scripts and modules. Update unit tests and mock controllers to the latest version of the ATTCS class updates. Fix take image call in take image script.. Update take image script. Fix open/close vents. Add missing await in add_point_data. Create `add_point_data` method to help add new pointing data. Fix call to open/close m1 vent method. Add open/close M1 vents. Add enable hexapod correction on startup. Add a new option to wait settle or not during a slew_icrs command. Fix rot_pa option in slew_icrs command. Add nasmyth to monitor_position. Trying to make wait_for_atmcs_inposition more robust for when slewing without stoping the mount. If running in non-stop tracking mode, clear in position event. In slew commands add an option to not stop tracking before slew. Implement filling up of track_id. Set default number of images to 1 in latiss.take_object and latiss.take_engtest. Remove wait for LFOA to latiss.take_image. Fix point_azel and atdometrajectory dependency when wait_dome is False. Fix bug in stop_tracking.
* develop: Implement changes to make code compatible with ts_observatory_control. Implement new ATCS and LATISS functionality on scripts. Moved classes to observatory control repo. Add additional scripts done during last AT run. Use taiTime or time, as appropriate Fix time->taiTime in an ATMCS command and event. Build idl files for each component individually to work around sal + xml issues. Will fix that once sal 4.1 is released. Fix flake8 warnings Add a git pre-commit hook to format with black Format code with black
* develop: Flatten tests directory to work around a pytest limitation Add stop scripts and tests for them. Add missing boilerplate Rename main to maintel for main telescope scripts Fix boilerplate: T&S instead of DM Update scripts to use ``amain``. Fix import statements and unit tests for latest version of ts_observatory_control.
* develop: Implement latest PR review comments. Implement first round of PR comments. Pass script log attribute to the classes on all Scripts that uses ts_observatory_control classes. This guarantees that the log from the underlying task is logged to the EFD.
* develop: Lock black version to 19.10b0 Remove unnecessary f-string on base_track_target. Implement different rotator strategies in track_target script. Update interface to latest version of ts_observatory_control. Disable concurrent builds. Remove unnecessary ups cfg file, which was causing scons to fail.
* develop: removed print statements from format_as_list utility added format_as_list to utils Use `salobj.name_to_name_index` in `set_summary_state`. This fixes the issue with regular expression that cause it to fails with components that had numbers in their name, e.g.; MTM2 and MTM1M3. Add new script RunCommand, that allows one to run any command from a CSC and (optionally) wait for an event. Add new option on BaseTrackTarget to “track target” for a specified duration. This allows us to mimic a visit with exposure.
* develop: Fix f-string in `base_track_target`.
* develop: Remove `pytest-runner` from `setup.py` `setup_requires` section. Squashed commits: Increase timeout to start components in dome trajectory test. Set random dds partition in `check_executable`. Increase timeout to make scripts. Use `set_random_lsst_dds_partition_prefix` instead of `set_random_dds_domain`. Update conda recipe with latest ts-conda-build. Implement fixes for xml 7
* develop: DM-28187: Update ts_observatory_control and ts_standardscript to remove NewMTMount. Replace NewMTMount with MTMount in enable_mtcs and standby_mtcs scripts. Add group_id and note to BaseTakeImage script. Implementing Jenkins shared library Implementing Jenkins shared library
* commit 'f7fd3056dff32211d2a66175ae4a36ab5eac2e26': Update Jenkinsfile to fetch/prune git repos during build. Replace startup -> prepare_for_onsky. Fix run method in auxtel.prepare_for_onsky.
* develop: DM-29506: Support black upgrade * Reformat code using black 20. * Enabled pytest-black. * Pin version of ts-conda-build to 0.3 in conda recipe. * Update documentation format. On auxtel integration test dometrajectory_mcs Implement compatibility with xml 8.1.
* develop: Update version history. Making requested fix. Add offline scripts for maintel. Add offline scripts for auxtel.
* develop: Update setup_mtcs.py with TODO Update version_history.rst Update maintel/setup_mtcs.py to include home for the mount ... Update version history. Implement track_target_and_take_image_gencam script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.