Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(desktop): print warning if we can't parse custom protocol instead of showing error in UI #1320

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(desktop): print warning if we can't parse custom protocol instead of showing error in UI #1320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions desktop/src-tauri/src/custom_protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::ui_messages::{
UiMessage,
};
use crate::AppState;
use log::{error, info};
use log::{error, info, warn};
use serde::{Deserialize, Serialize};
use std::env;
use std::path::Path;
Expand Down Expand Up @@ -169,13 +169,7 @@ impl CustomProtocol {
let request = UrlParser::parse(&url_scheme.to_string());
let app_state = app_handle.state::<AppState>();
if let Err(err) = request {
#[cfg(not(target_os = "windows"))]
send_ui_message(
app_state,
UiMessage::CommandFailed(err),
"Failed to broadcast custom protocol message",
)
.await;
warn!("Failed to broadcast custom protocol message: {:?}", err);
return;
}
let request = request.unwrap();
Expand Down
Loading