Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): print warning if we can't parse custom protocol instead of showing error in UI #1320

Conversation

pascalbreuninger
Copy link
Member

This feature caused issues on both linux and windows. We should still be
able to properly detect issues by checking out the application logs

showing error in UI

This feature caused issues on both linux and windows. We should still be
able to properly detect issues by checking out the application logs
@pascalbreuninger pascalbreuninger requested a review from a team October 18, 2024 07:18
@pascalbreuninger pascalbreuninger linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit aaa58e9 into loft-sh:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"InvalidQuery: version"
2 participants