-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ena_deposition): Make deposition a package instead of multiple snakemake rules #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
changed the title
Refactor ena deposition
feat(ena_deposition): Make deposition a package instead of multiple snakemake rules
Oct 9, 2024
anna-parker
commented
Oct 10, 2024
anna-parker
force-pushed
the
refactor_ena_deposition
branch
3 times, most recently
from
October 18, 2024 13:33
f1e62f1
to
d733eeb
Compare
corneliusroemer
force-pushed
the
refactor_ena_deposition
branch
from
October 18, 2024 14:01
92ccada
to
df622dc
Compare
corneliusroemer
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice DRYification!
Co-authored-by: Cornelius Roemer <[email protected]>
Co-authored-by: Cornelius Roemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2878
preview URL: https://refactor-ena-deposition.loculus.org/
Problem
If one snakemake rule fails the other rules will keep running indefinitely. We should stop other rules if one fails.
Summary
create_project
,create_sample
,create_assembly
,trigger_submission
andupload_external_metadata
functions are run in parallel threads (instead of before being run in parallel snakemake rules) and use stop_event to stop all threads if one fails.Tested that this works as intended on a preview by causing an Exception to be raised in the
trigger_submission
function thread - this lead to all other threads being stopped and the pod stopping and being restarted by kubernetes:Additional changes:
xmltodict
working differently than before. I needed to create a new class calledXmlNone
for the case when a field is intentionally left None in the dictionary, e.g.SEQUENCING_PROJECT
in the xml below:logging
in all files - leading tologger
being changed tologging
in multiple files.secure_ena_connection
function to check if connections to ENA are done correctly instead of doing this at the start of the snakefile.Screenshot
PR Checklist