-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(box libfuncs): use BlockExt trait #545
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e02137
refactor(box libfuncs): use BlockExt trait
FeliGR 75bc272
fix: remove unnecessary i64 cast and relocate operations to init block
FeliGR 49c5021
Merge branch 'main' into refactor-box-libfuncs
FeliGR 641468a
Merge branch 'main' into refactor-box-libfuncs
edg-l dc93d1f
fix: add .pad_to_align() to inner_layout.size()
FeliGR f9d1f83
Merge branch 'main' into refactor-box-libfuncs
FeliGR 1d62498
Merge branch 'main' into refactor-box-libfuncs
FeliGR 7e39991
Merge branch 'main' into refactor-box-libfuncs
FeliGR b782a6c
fix(box): resolve merge conflicts
FeliGR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here this should be refactored using
append_op_result
no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and the next operation too (the ReallocBindingsMeta::realloc).