refactor(box libfuncs): use BlockExt trait #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeliGR
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
edg-l
requested changes
Apr 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 88.85% 88.69% -0.17%
==========================================
Files 108 108
Lines 34555 34242 -313
==========================================
- Hits 30705 30372 -333
- Misses 3850 3870 +20 ☔ View full report in Codecov by Sentry. |
edg-l
previously approved these changes
Apr 25, 2024
azteca1998
reviewed
Apr 25, 2024
azteca1998
previously approved these changes
Apr 25, 2024
edg-l
previously approved these changes
May 6, 2024
juanbono
previously approved these changes
May 8, 2024
|
Please fix conflict @FeliGR |
juanbono
approved these changes
May 14, 2024
juanbono
approved these changes
May 14, 2024
tcoratger
reviewed
Jun 4, 2024
| )) | ||
| .result(0)? | ||
| .into(); | ||
| let value_len = entry.const_int(context, location, inner_layout.pad_to_align().size(), 64)?; | ||
|
|
||
| let ptr = entry | ||
| .append_operation(llvm::nullptr(opaque_pointer(context), location)) |
There was a problem hiding this comment.
Here this should be refactored using append_op_result no?
There was a problem hiding this comment.
Yes, and the next operation too (the ReallocBindingsMeta::realloc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist