Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vietnamese translation #2716

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

nghiahsgs
Copy link
Contributor

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Sep 22, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Sep 22, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Sep 22, 2024
@nghiahsgs
Copy link
Contributor Author

@@ -163,7 +163,7 @@
"DescSingleNode": " <p> Khi chạy một phiên, nút được quản lý và các nút công nhân được đặt trên một nút vật lý hoặc máy ảo duy nhất. </p>",
"DescMultiNode": " <p> Khi chạy một phiên, một nút được quản lý và một hoặc nhiều nút công nhân được chia thành nhiều nút vật lý hoặc máy ảo. </p>",
"CPU": "CPU",
"Memory": "Ký ức",
"Memory": "Bộ nhớ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both "Ký ức" and "Bộ nhớ" are translated as "memory" in English. Therefore, I inquired with ChatGPT about the distinctions between these two terms.

In Vietnamese, "Ký ức" and "Bộ nhớ" have distinct meanings:

Ký ức: This term refers to memory in the psychological or emotional sense, often related to personal experiences, recollections, or memories that individuals hold.

Bộ nhớ: This term specifically refers to memory in a technical context, particularly in computing. It denotes the hardware or storage used in computers and devices to store data temporarily or permanently.

So, for computer memory, "Bộ nhớ" is the correct term to use.

@rapsealk rapsealk added this to the 24.03 milestone Oct 3, 2024
@rapsealk
Copy link
Member

rapsealk commented Oct 3, 2024

LGTM. Could you please review it once more, @agatha197? Thank you.

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Oct 3, 2024

Merge activity

  • Oct 3, 2:18 AM EDT: agatha197 added this pull request to the Graphite merge queue.
  • Oct 3, 2:18 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@rapsealk rapsealk merged commit 55f1003 into lablup:main Oct 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants