Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: prevent stacking of duplicate notifications #2502

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feature: prevent stacking of duplicate notifications #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/backend-ai-session-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,6 @@ export default class BackendAISessionList extends BackendAIPage {
}, refreshTime);
}
this._listStatus?.hide();
console.log(err);
if (err && err.message) {
this.notification.text = PainKiller.relieve(err.title);
this.notification.detail = err.message;
Expand Down
39 changes: 27 additions & 12 deletions src/components/lablup-notification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,30 +177,46 @@ export default class LablupNotification extends LitElement {
*
* @param {boolean} persistent - if persistent is false, the snackbar is hidden automatically after 3000ms
* @param {object} log - Log object that contains detail information
* @param {string} key - notification key. If it already exists, the notification will be updated.
* */
show(persistent = false, log: Record<string, unknown> = Object()) {
show(
persistent = false,
log: Record<string, unknown> = Object(),
key: string,
) {
if (this.text === '_DISCONNECTED') {
return;
}
const shouldSaveLog = Object.keys(log).length !== 0;
if (shouldSaveLog) {
console.log(log);
this._saveToLocalStorage('backendaiwebui.logs', log);
}

const messageDetail = {
open: true,
type: shouldSaveLog ? 'error' : null,
message: this.text,
description: this.text ? undefined : this.detail,
to: shouldSaveLog ? '/usersettings?tab=logs' : this.url,
duration: persistent ? 0 : undefined,
// closeIcon: persistent,
};

const event: CustomEvent = new CustomEvent('add-bai-notification', {
detail: {
open: true,
type: shouldSaveLog ? 'error' : null,
message: this.text,
description: this.text ? undefined : this.detail,
to: shouldSaveLog ? '/usersettings?tab=logs' : this.url,
duration: persistent ? 0 : undefined,
// closeIcon: persistent,
key:
typeof key === 'undefined' && messageDetail.type === 'error'
? `_no_key_from_lablup_notification:${JSON.stringify(messageDetail)}`
: key,
...messageDetail,
},
});
document.dispatchEvent(event);
this._spawnDesktopNotification('Backend.AI', this.text, '');

// Ignore the event if the message is 'Network disconnected because it is handled by `NetworkStatusBanner` component.
if (messageDetail.message !== 'Network disconnected.') {
document.dispatchEvent(event);
this._spawnDesktopNotification('Backend.AI', this.text, '');
}
}

// /**
Expand Down Expand Up @@ -325,7 +341,6 @@ export default class LablupNotification extends LitElement {
* @param {string} logMessages - Message to save
* */
_saveToLocalStorage(key, logMessages) {
console.log(logMessages);
const previous_log = JSON.parse(localStorage.getItem(key) || '{}');
let current_log: Array<any> = [];

Expand Down
Loading