feature: prevent stacking of duplicate notifications #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
6 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
ironAiken2
requested changes
Jul 1, 2024
There was a problem hiding this comment.
In cases where individual notifications are required, such as deleting a session, stopping another session will not cause a Notifiaction if a notification has already been upserted for the terminating or already terminating session.
How to test:
- delete a session.
- Delete another session without clearing the session deletion notification.
- Verify that the session deletion notification does not occur.
ironAiken2
force-pushed
the
feature/no-network-banner
branch
from
e7b5dbf
to
db62f9a
Compare
yomybaby
force-pushed
the
feature/prevent-staking-duplicated-notifications
branch
from
1a491b2
to
082820c
Compare
6 tasks
yomybaby
changed the title
yomybaby
changed the title
Merge activity
|
### TL;DR Removed unnecessary console log statements and improved notification handling by adding a unique key parameter to avoid duplicate notifications. ### What changed? - Removed `console.log` statements in `backend-ai-session-list.ts` and `lablup-notification.ts` files. - Enhanced the `show` method in `LablupNotification` component to include a `key` parameter for uniquely identifying notifications. - Added logic to prevent dispatching duplicate notifications and handled the 'Network disconnected' message specifically. ### How to test? 1. Trigger an error in the application and verify that console log statements no longer appear. 2. Check that notifications are correctly displayed without duplication. 3. Ensure the 'Network disconnected' message is handled by the `NetworkStatusBanner` component. ### Why make this change? To clean up the console output and improve the notification system by preventing duplicate messages and enhancing user experience. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/prevent-staking-duplicated-notifications
branch
from
082820c
to
e4145c4
Compare
graphite-app
bot
deleted the
feature/prevent-staking-duplicated-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed unnecessary console log statements and improved notification handling by adding a unique key parameter to avoid duplicate notifications.
What changed?
console.logstatements inbackend-ai-session-list.tsandlablup-notification.tsfiles.showmethod inLablupNotificationcomponent to include akeyparameter for uniquely identifying notifications.How to test?
NetworkStatusBannercomponent.Why make this change?
To clean up the console output and improve the notification system by preventing duplicate messages and enhancing user experience.
Checklist: (if applicable)