Add cluster label to aggregations in alert queries #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
approved these changes
May 26, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of alerts did not include the cluster label when doing aggregations.
As a result, in a multi-cluster environment, it could be difficult to identify which cluster was triggering the alert. Also, in some cases (such as the KubeVersionMismatch), differences between clusters would be mistakenly reported as alerts.
This resolves (portions of? possibly all?) #695
I tested the ones that I changed, which we received feedback on. I believe all the other alert queries are fine from a cursory review. They do not seem to have aggregations, which would remove the cluster label if present.
It's possible I still missed some tho.