KubeVersionMismatch for multiple clusters #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groups the versions by clusters so that we count distinct versions within a cluster and filter the clusters with more then one version. Then we alert based on number of such clusters
Updated description and summary
|
Hey, thanks for the patch. I see this PR overlaps a bit with #766. |
|
I see that #766 was already merged and the general idea of the change is the same. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the alter was fired when I added a new cluster with different kube version even when each cluster had consistent versions within itself.
The alert expression was modified to fire only when there are multiple versions of kube components within the same cluster.
This changes the meaning of the alert a bit, as before the alert was fired if any cluster had a different kube component version and after this change the alert won't fire as long as each cluster is consistent within itself.