Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JAX image to use image published by Kubeflow #2264

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Update JAX image to use image published by Kubeflow #2264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
727f7fc
Use JAX image published by Kubeflow
sandipanpanda Sep 20, 2024
374ee5d
Update README to include JAX API Definition
sandipanpanda Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

Kubeflow Training Operator is a Kubernetes-native project for fine-tuning and
scalable distributed training of machine learning (ML) models created with various ML frameworks
such as PyTorch, TensorFlow, HuggingFace, Jax, DeepSpeed, XGBoost, PaddlePaddle and others.
such as PyTorch, TensorFlow, HuggingFace, [JAX](https://jax.readthedocs.io/en/latest/), DeepSpeed, XGBoost, PaddlePaddle and others.

You can run high-performance computing (HPC) tasks with the Training Operator and `MPIJob` since it
supports running Message Passing Interface (MPI) on Kubernetes which is heavily used for HPC.
Expand Down Expand Up @@ -103,6 +103,7 @@ For a complete reference of the custom resource definitions, please refer to the
- [XGBoost API Definition](pkg/apis/kubeflow.org/v1/xgboost_types.go)
- [MPI API Definition](pkg/apis/kubeflow.org/v1/mpi_types.go)
- [PaddlePaddle API Definition](pkg/apis/kubeflow.org/v1/paddlepaddle_types.go)
- [JAX API Definition](pkg/apis/kubeflow.org/v1/jax_types.go)

For details on the Training Operator custom resources APIs, refer to
[the following API documentation](docs/api/kubeflow.org_v1_generated.asciidoc)
Expand Down
2 changes: 1 addition & 1 deletion examples/jax/cpu-demo/demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
spec:
containers:
- name: jax
image: docker.io/sandipanify/jaxgoogle:latest
image: docker.io/kubeflow/jaxjob-simple:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that there is this image in the DockerHub: https://hub.docker.com/r/kubeflow/jaxjob-simple/tags

command:
- "python3"
- "train.py"
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller.v1/jax/envvar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestSetPodEnv(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "jax",
Image: "docker.io/sandipanify/jaxgoogle:latest",
Image: "docker.io/kubeflow/jaxjob-simple:latest",
Ports: []corev1.ContainerPort{{
Name: kubeflowv1.JAXJobDefaultPortName,
ContainerPort: validPort,
Expand Down
2 changes: 1 addition & 1 deletion pkg/webhooks/jax/jaxjob_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestValidateV1JAXJob(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "jax",
Image: "docker.io/sandipanify/jaxgoogle:latest",
Image: "docker.io/kubeflow/jaxjob-simple:latest",
Ports: []corev1.ContainerPort{{
Name: "jaxjob-port",
ContainerPort: 6666,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/training/constants/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
JAXJOB_PLURAL = "jaxjobs"
JAXJOB_CONTAINER = "jax"
JAXJOB_REPLICA_TYPES = REPLICA_TYPE_WORKER.lower()
JAXJOB_BASE_IMAGE = "kubeflow/jaxjob-simple:latest"
JAXJOB_BASE_IMAGE = "docker.io/kubeflow/jaxjob-simple:latest"

# Dictionary to get plural, model, and container for each Job kind.
JOB_PARAMETERS = {
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/test/e2e/test_e2e_jaxjob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def generate_jaxjob(
def generate_container() -> V1Container:
return V1Container(
name=CONTAINER_NAME,
image="docker.io/sandipanify/jaxgoogle:latest",
image="docker.io/kubeflow/jaxjob-simple:latest",
command=["python", "train.py"],
resources=V1ResourceRequirements(limits={"memory": "2Gi", "cpu": "0.8"}),
)
Loading