Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JAX image to use image published by Kubeflow #2264

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

sandipanpanda
Copy link
Contributor

Follow up of #2194

/area gsoc

@sandipanpanda
Copy link
Contributor Author

/cc @tenzen-y @terrytangyuan

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve
/hold for CI

@@ -12,7 +12,7 @@ spec:
spec:
containers:
- name: jax
image: docker.io/sandipanify/jaxgoogle:latest
image: docker.io/kubeflow/jaxjob-simple:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that there is this image in the DockerHub: https://hub.docker.com/r/kubeflow/jaxjob-simple/tags

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10962850781

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10961524178: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls

@tenzen-y
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit da11d11 into kubeflow:master Sep 20, 2024
40 checks passed
@sandipanpanda sandipanpanda deleted the update-jax-image branch September 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants