Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: adding required setting to properties file #13

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Oct 9, 2024

With out this fix, I am getting:

s3-sink-deployment-7886f69cc-khspt sink Caused by: java.lang.IllegalArgumentException: Route template aws-s3-sink the following mandatory parameters must be provided: bucketNameOrArn, region
s3-sink-deployment-7886f69cc-khspt sink 	at org.apache.camel.impl.DefaultModel.addRouteFromTemplate(DefaultModel.java:477)
s3-sink-deployment-7886f69cc-khspt sink 	at org.apache.camel.impl.DefaultModel.addRouteFromTemplate(DefaultModel.java:416)
s3-sink-deployment-7886f69cc-khspt sink 	at org.apache.camel.impl.DefaultCamelContext.addRouteFromTemplate(DefaultCamelContext.java:362)
s3-sink-deployment-7886f69cc-khspt sink 	at org.apache.camel.component.kamelet.KameletComponent$LifecycleHandler.createRouteForEndpoint(KameletComponent.java:433)
s3-sink-deployment-7886f69cc-khspt sink 	... 28 more
s3-sink-deployment-7886f69cc-khspt sink 

@matzew
Copy link
Contributor Author

matzew commented Oct 9, 2024

@christophd can we perhaps update the archetype to also set this to empty (e.g. all required)?

At least temporary, until we know why this is needed?

Copy link
Contributor

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense to generate the required properties in the archetype. I am investigating why this is default empty value is required

Copy link

knative-prow bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d604458 into knative-extensions:main Oct 9, 2024
3 checks passed
@matzew matzew changed the title adding required setting to properties file S3: adding required setting to properties file Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants