Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS: adding required setting to properties file #15

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Oct 9, 2024

Similar to #13

also related to #14

@matzew
Copy link
Contributor Author

matzew commented Oct 9, 2024

/assign @christophd

@knative-prow knative-prow bot added the lgtm label Oct 10, 2024
Copy link

knative-prow bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ffd721c into knative-extensions:main Oct 10, 2024
3 checks passed
@matzew matzew changed the title adding required setting to properties file SQS: adding required setting to properties file Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants