add appProtocol to hub service definition #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finding https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/#ServiceSpec i think this is perfectly fine to make configurable |
consideRatio
approved these changes
Oct 2, 2024
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 2, 2024
jupyterhub/zero-to-jupyterhub-k8s#3534 Merge pull request #3534 from colinlodter/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3533 and allows
appProtocolto be set on thehubService defintion.