Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add appProtocol to the hub Service schema #3533

Closed
colinlodter opened this issue Oct 2, 2024 · 1 comment
Closed

add appProtocol to the hub Service schema #3533

colinlodter opened this issue Oct 2, 2024 · 1 comment
Labels

Comments

@colinlodter
Copy link
Contributor

Bug description

In our specific use case, we were attempting to scrape Prometheus metrics from JupyterHub's hub pod. In our environment, this is done within an Istio Service Mesh. Prometheus attempts to request the /metrics endpoint using HTTP/2 which Tornado does not support and generates error messages like the following:

 HTTP message from 127.0.0.6: Malformed HTTP version in HTTP Request-Line: 'HTTP/2.0' 

How to reproduce

  1. Deploy JupyterHub to a kubernetes cluster with Istio enabled and the standard hub Service manifest.
  2. Set up a Prometheus ServiceMonitor for the hub Service.
  3. Tail istio-proxy or hub container logs.

Expected behaviour

Allow appProtocol to be set on the hub service (i.e. set to http to "downgrade" requests to the hub service) and specify appProtocol as http.

Actual behaviour

hub application generates errors when HTTP/2 requests are received.

@consideRatio
Copy link
Member

Fixed by #3534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants