[develop/fetch] Suppress TF Duplicated stamp warning in noetic client PC #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktometometo
approved these changes
Nov 2, 2023
|
Tested on real robot |
|
Looks good to me. You don't need to give a concrete answer, but I am interested in what strange behaviors occurred. |
mqcmd196
changed the title
|
Still shows |
tkmtnt7000
previously approved these changes
Nov 2, 2023
Thank you. I see. |
mqcmd196
commented
Nov 2, 2023
| @@ -111,7 +111,12 @@ | |||
| false, false, false] | |||
| odom0_nodelay: true | |||
| odom0_differential: true | |||
| permit_corrected_publication: false | |||
There was a problem hiding this comment.
@sktometometo
Setting this param to false suppresses the warning. Was your first commit wrong?
mqcmd196
changed the title
tkmtnt7000
approved these changes
Nov 2, 2023
|
Thank you ! @tkmtnt7000 I'll merge now for the next semi. Please contact me if you have a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #1876 .
@sktometometo did the work #1877 , but it causes some strange behavior in the real robot. So I want to adopt the patch only for suppressing the warning. Upstream PR is cra-ros-pkg/robot_localization#840