Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for targetextension config option #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ninja.lua
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
--
--
-- Name: premake-ninja/ninja.lua
-- Purpose: Define the ninja action.
-- Author: Dmitry Ivanov
Expand Down Expand Up @@ -635,7 +635,7 @@ function ninja.generateProjectCfg(cfg)
p.w("# link shared lib")

local extra_outputs = {}
if ninja.endsWith(output, ".dll") then
if ninja.endsWith(output, ".dll") or toolset == p.tools.msc then
extra_outputs = { ninja.noext(output, ".dll") .. ".lib", ninja.noext(output, ".dll") .. ".exp" }
elseif ninja.endsWith(output, ".so") then
-- in case of .so there are no corresponding .a file
Expand Down