Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for targetextension config option #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p0358
Copy link
Contributor

@p0358 p0358 commented Jul 4, 2023

With Premake you can specify the option to change target file's extension like this: targetextension ".aes"

This would cause the check I fixed to fail, as the extension isn't .dll. Not sure if my fix for this is perfect, but I don't think MSVC can build non-Windows libraries, so it should be fine?

This fails the gcc test though, but honestly I don't have any better ideas for now. But for now better to partially fix than not at all, unless you have any better ideas...

@Jarod42
Copy link
Collaborator

Jarod42 commented Jul 7, 2023

Unclear what you expect to happens with targetextension ".aes"...
I agree that current test for extra files is not ideal for now...

@p0358
Copy link
Contributor Author

p0358 commented Jul 7, 2023

It should simply override the output file's extension from the default exe and dll, it's supported by core, and in my case I'm compiling a replacement DLL where someone originally for some reason decided to just rename the extension from .dll to .aes (it doesn't make much sense, but there is such option and Windows has no issues with that either)

@Jarod42
Copy link
Collaborator

Jarod42 commented Jul 13, 2023

Should be fixed by 3077d47

using os.target() == "windows" for dll/lib stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants