Proposed changes to maven coordinates for consistency in EE 12 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleAure
changed the title
pzygielo
reviewed
Jul 9, 2024
KyleAure
force-pushed
the
proposed-coordinate-updates-ee-12
branch
2 times, most recently
from
51ad3a0
to
97f9baf
Compare
arjantijms
approved these changes
Sep 15, 2024
pzygielo
reviewed
Sep 16, 2024
KyleAure
force-pushed
the
proposed-coordinate-updates-ee-12
branch
2 times, most recently
from
326ff03
to
2fd7300
Compare
pzygielo
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
I've built locally api and relocation/api and it gives on usage of old GAV:
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The artifact jakarta.enterprise.concurrent:jakarta.enterprise.concurrent-api:jar:3.2.0-SNAPSHOT has been relocated to jakarta.concurrent:jakarta.concurrent-api:jar:3.2.0-SNAPSHOT
I think this is perfect.
The task left to do - is to include the step in Jenkins release job (but this PR has to land in main first of course) or include relocation in top-level project.
This comment was marked as resolved.
This comment was marked as resolved.
KyleAure
force-pushed
the
proposed-coordinate-updates-ee-12
branch
from
7b991be
to
4e24c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes to maven coordinates