Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project in preperation for Jakarta EE 12 #537

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Jun 21, 2024

  • Java versions: 17 + 21 -> 21 + 25
  • Project version: 3.1.1-SNAPSHOT -> 3.2.0-SNAPSHOT

@KyleAure KyleAure changed the title Update spec in preperation for Jakarta EE 12 Update project in preperation for Jakarta EE 12 Jun 21, 2024
@KyleAure KyleAure self-assigned this Jun 24, 2024
@KyleAure KyleAure added the version Simple version update label Jun 24, 2024
@KyleAure KyleAure force-pushed the prepare-for-jakarta-ee-12 branch 2 times, most recently from d6860ba to f406dce Compare July 9, 2024 16:41
@njr-11
Copy link
Contributor

njr-11 commented Jul 9, 2024

Let's not change maven coordinates until it is decided that specifications will need to do so for Jakarta EE 12. I know the proposal was brought up today on the Jakarta Platform call, but we don't know yet if it will be agreed on. A change of coordinates for the sake of consistency across Jakarta EE specifications also needs to be weighed against the loss of consistency between versions of the Jakarta EE specification itself. Currently, it is nice that a developer can see all of the versions side by side and it is very obvious which is the latest. I think that would be lost if changing coordinates.

@KyleAure
Copy link
Contributor Author

KyleAure commented Jul 9, 2024

@njr-11 I pulled those changes out into a separate PR #555 that we can leave in draft state until we have more consensus on this type of change.

@KyleAure KyleAure added this to the 3.2.0 milestone Jul 9, 2024
@arjantijms
Copy link
Contributor

Let's not change maven coordinates until it is decided that specifications will need to do so for Jakarta EE 12. I know the proposal was brought up today on the Jakarta Platform call, but we don't know yet if it will be agreed on

We can just decide to do it here. The Authentication API did this a while ago as well. I checked before doing that, and we don't need to be forced by the platform to do it.

Consistency is good, and at the moment concurrency is one of the few exceptions to an otherwise pretty consistent naming scheme.

@KyleAure KyleAure merged commit c7af8f9 into jakartaee:main Jul 9, 2024
2 checks passed
@KyleAure KyleAure deleted the prepare-for-jakarta-ee-12 branch July 9, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version Simple version update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants