fix: retain scroll position when going back #1030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡ Lighthouse report for the home page 🏠
Other pages
|
|
Attaching the quick video of a side effect: if you go back and then forward the scroll position is wrong, and if you go back again the position is lost and the viewport jumps to the top. Screencast.from.2023-10-24.19-27-02.webm |
|
Another feeling I got, we talked about this earlier is: Gatsby has this feature out of the box, and we are not doing anything out of the ordinary that warrants for a special treatment of the scrolling (are we?). Why do we need to manually set it up? I feel we are missing something in the way this works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.