Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retain scroll position when going back #916

Closed
wants to merge 1 commit into from
Closed

fix: retain scroll position when going back #916

wants to merge 1 commit into from

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Sep 30, 2023 •
edited
Loading

Fix #883.

@bfabio
Copy link
Member Author

bfabio commented Sep 30, 2023

This was introduced in ab365e6, and judging by the commit message it was trying to fix something else.

@astagi do you remember what it was?

@bfabio bfabio requested a review from astagi September 30, 2023 18:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023 •
edited
Loading

⚡ Lighthouse report for the home page 🏠

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 98

See the full report...

Other pages

@Fupete
Copy link
Collaborator

Fupete commented Nov 8, 2023

@astagi @bfabio same comment as the other PR to address same issues: how are we doing? Any news?

@Fupete Fupete added the bug label Nov 8, 2023
@Fupete Fupete closed this Nov 14, 2023
@bfabio
Copy link
Member Author

bfabio commented Nov 14, 2023

Continues in #1030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagi astagi Awaiting requested review from astagi

Assignees
No one assigned
Labels
bug
Projects
Designers Italia - Website
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser's back button resets scroll to zero
2 participants
@bfabio @Fupete