Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: switch from testing against js-ipfs to helia #10042

Merged
merged 2 commits into from
Aug 2, 2023
Merged

ci: switch from testing against js-ipfs to helia #10042

merged 2 commits into from
Aug 2, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 1, 2023 •
edited
Loading

Fixes #10013

@Jorropo Jorropo added the skip/changelog This change does NOT require a changelog entry label Aug 1, 2023
@Jorropo Jorropo requested a review from a team as a code owner August 1, 2023 14:48
@Jorropo Jorropo force-pushed the helia-interop branch 4 times, most recently from c70a866 to f010231 Compare August 1, 2023 15:02
@Jorropo Jorropo force-pushed the helia-interop branch 3 times, most recently from 2447510 to 5415496 Compare August 1, 2023 15:17
@hacdias
Copy link
Member

hacdias commented Aug 1, 2023 •
edited
Loading

Just a quick comment: removing the following should also be done (as well as any other instructions that relate to interop):

kubo/docs/RELEASE_ISSUE_TEMPLATE.md

Lines 177 to 182 in 89b0432

- [ ] ![](https://img.shields.io/badge/only-FINAL-green?style=flat-square) Update Kubo in [interop](https://github.com/ipfs/interop) <details><summary>using `./kuboreleaser release --version vX.Y.Z(-rcN) update-interop` or ...</summary>
- [ ] ![](https://img.shields.io/badge/only-FINAL-green?style=flat-square) check out [ipfs/interop](https://github.com/ipfs/interop)
- [ ] ![](https://img.shields.io/badge/only-FINAL-green?style=flat-square) run `npm install`
- [ ] ![](https://img.shields.io/badge/only-FINAL-green?style=flat-square) create a PR which updates `package.json` and `package-lock.json`
- [ ] ![](https://img.shields.io/badge/only-FINAL-green?style=flat-square) merge the PR
</details>

cc @galargh to remove the command from kuboreleaser: ipfs/kuboreleaser#18

@Jorropo Jorropo force-pushed the helia-interop branch 10 times, most recently from 63390f7 to f413ad8 Compare August 1, 2023 18:03
@BigLep
Copy link
Contributor

BigLep commented Aug 1, 2023

Just a quick comment: removing the following should also be done (as well as any other instructions that relate to interop):
cc @galargh to remove the command from kuboreleaser

Good call on updating the release process.
We (Kubo maintainters) should go and own updating kuboreleaser. It's Kubo's tool (that IPDX built for us). Obviously a nice bonus if IPDX can pick it up, but we shouldn't wait on them.

hacdias
hacdias reviewed Aug 2, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@hacdias hacdias mentioned this pull request Aug 2, 2023
Merged
@Jorropo Jorropo merged commit 5bec4d6 into master Aug 2, 2023
9 checks passed
@Jorropo Jorropo deleted the helia-interop branch August 2, 2023 15:01
@BigLep BigLep mentioned this pull request Aug 3, 2023
Closed
@galargh galargh mentioned this pull request Aug 3, 2023
Closed
@galargh
Copy link
Contributor

galargh commented Aug 3, 2023

Post merge LGMT, thank you for doing this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki left review comments

@hacdias hacdias hacdias approved these changes

Assignees

@Jorropo Jorropo

Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test interoperability with Helia and remove dependency on ipfs/interop
5 participants
@Jorropo @hacdias @BigLep @galargh @SgtPooki