Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tag checkout in the interop workflow #10046

Closed
wants to merge 1 commit into from
Closed

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Aug 3, 2023

IIRC we're going to have to fetch tags first for the latest tag checkout to work as expected. BTW, thank you for putting up #10042 🙇 ❤️

@galargh galargh added the skip/changelog This change does NOT require a changelog entry label Aug 3, 2023
@galargh galargh requested a review from Jorropo August 3, 2023 07:04
@galargh galargh requested a review from a team as a code owner August 3, 2023 07:04
export TAG="$(git describe --tags --abbrev=0)"
echo "Running tests against: $TAG"
git checkout "$TAG"
git fetch --tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fetch-depth: 0

Suggested change
git fetch --tags

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't know about this. Thanks. I'm going to close this then :)

@galargh
Copy link
Contributor Author

galargh commented Aug 3, 2023

This is obsolete because #10046 (comment)

@galargh galargh closed this Aug 3, 2023
@galargh galargh deleted the ci-tag-fetch branch August 3, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants