fix(combobox): unexpected overlay opening #2369
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added condition to check if overlay should be opened, but this change breaks 17 unit tests due to differences between programmatic actions in unit tests and actual UI behavior. Verified that affected scenarios function as expected in the UI.
Unit tests need further work as discussed with @okadurin. He confirmed the unexpected unit tests behavior.
Reproduction scenario of a bug I am trying to fix:
_showOverlayCondition
withreturn false
to simplify the use case when subclassers override this method and return false due to some logic.Please see what kind of fix could be applied to unit tests.