-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Introduce Playwright for e2e testing #2370
Conversation
|
sendKeys is a wrapper around Playwright functions. So no need to bring Playwright separately. |
web test runner
is not reliable when it comes to keyboard interaction and Playwright seems more advanced. It provides a high level API for filling out the text, interacts with the browser from the Node side as if a user typed the text. As a result the Keyboard events generated in the right order so we don't need guess how manyupdateComplete
cycles to wait. We can consider using Playwright for testing when keyboard interaction is required.See more details regarding the PR in the added documentation
Here are the same tests written in
web test runner
and with Playwright for comparison:doesn't select any similar options after using delete when requireOptionMatch is false
: wtr, playwrightallows new options when multi-choice when requireOptionMatch=false and autocomplete="both
: wtr, playwrighthides listbox on click/enter (when multiple-choice is false)
: wtr, playwrightAnd here is the test where it detects whether the popup window flashed during the key typing: Combobox does not flash the menu when _showOverlayCondition returns "false". I checked it with the fix PR and the test passes.