-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new rules for signatures and witness events #402
Conversation
now that signature is stored on the revision that injects it (not on the one that was current at the time of signing), verification though external verifier fails. Also, Verifier is freaking out in general |
We will have a look today and test. Will get back with any feedback I have. Thank you Dejan! |
Find an example JSON page. The Witness object exists but the path with the merkle-tree-path is completly missing. 6c3fbf41e5_Testpage_Witness.json Signatures_hash must be included when caluclating the verification hash of the revision, which also stores the signature. Currently the signature hash is ignored. See example manipulated page I used for testing the signature (it should work if I put the signature back into the first revision, the verifier should return green as the second revision takes the signature hash as input to calculate the revision hash).
The same problem persists with the witness hash, it is not included in the hasher but should be included.
|
Updated commit, hopefully all is good now |
Signature is tested and works. Verifier needs adjustment. |
Witness data is malformatted and at the wrong place for verifier to process. cf4f30f866_Interactive_Tutorial.json "structured_merkle_proof": [] is still empty in the second revision and is now populated at the wrong position witness_slot in content. The structured merkle proof needs to be stored as JSON in the witness object outside of the content. The witness-slot does contain now all verification data (including merkle-tree-proof). Its redudent to the witness data in the JSON and not required in full length in there as it is invisibile to the user anyway at this moment. |
Like the Signature field: The Witness field should include useful user information about the witness event. Those information are:
Successcreteria:
|
#397