Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint to get recent changes #403

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

it-spiderman
Copy link
Collaborator

Normal API is updated deferred and also doesnt work well for Imported pages

#401

Issue: normal recent changes endpoint does return imported pages, buut, those revisions will have timestamp or the original revision, ie. not the timestamp of import, but of original creation. We cannot change this, as timestamp is included in hash. Also, it is update on deferred updates, so page will take some time to appear on RC after change.

Use the new API that is specifically done for your use-case. Its updated immediately and will show time of the import as the "last change" timestamp (without affecting original revision timestamp)

See updated API docu for more info: /data_accounting/recent_changes

Normal API is updated deferred and also doesnt work well for Imported pages

#401
@it-spiderman
Copy link
Collaborator Author

CI failures will be fixed with #402

@FantasticoFox
Copy link
Collaborator

FantasticoFox commented Jun 26, 2024

Can you please provide an example how to use the timestamp?
Format is descripted in the API but not clear how the parameter is provided as an input for the endpoint.

I assume it works with ?since= &count =

@FantasticoFox
Copy link
Collaborator

We require that deleted revisions are shown by the API.
We require the funcitonality so we can see deletion events to update Guardian state.
This can be provided by this API.

This could also be done by extending the query arguments with another Argument

  • hide_deletion = true / false

When not providing any query arguments, it should not show deletion events when showing all pages (latests) without any query input.

@it-spiderman
Copy link
Collaborator Author

Usage is described in the API docu. To use timestamp, specify since=20240101000000 (YmdHis), same format as timestamp that is returned in the items of the API response

@FantasticoFox
Copy link
Collaborator

I'll close and merge this one and move our comment into the old specification issue #383

@FantasticoFox FantasticoFox merged commit d34f8e3 into main Jun 27, 2024
1 of 4 checks passed
@FantasticoFox FantasticoFox deleted the new_recent_changes branch June 27, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants