Basic Multiplayer UI #774
Draft
Basic Multiplayer UI #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will probably conflict # Conflicts: # Assets/Scenes/Main.unity
# Conflicts: # Assets/Scripts/Multiplayer/MultiplayerInterfaces.cs # Assets/Scripts/Multiplayer/MultiplayerManager.cs
# Conflicts: # Assets/Scripts/PassthroughManager.cs
[CI BUILD]
# Conflicts: # Assets/Settings/Localization/Strings/Strings Shared Data.asset # Assets/Settings/Localization/Strings/Strings_en.asset
# Conflicts: # Assets/Settings/Localization/Strings/Strings_en.asset
-Implemented global command: MultiplayerJoinRoom. -Updated the multiplayer panel prefab and manager. -Changed the admin panel layout from hexagon to octagon. TODO: -Add room name editing capabilities.
…open-brush into multiplayer/ui
- Added initialization of the keyboard with the current room name in `MultiplayerPanelButton.cs`. - Changed `SetRoomName` to a property (`RoomName`) in `MultiplayerPanel.cs` for better readability and encapsulation. - Updated `SketchControlScript.cs` to use the new `RoomName` property.
-MultiplayerManager: Added DoesRoomNameExist() and updated m_RoomData for room validation. -MultiplayerPanel: Added UpdateRoomExistenceMessage() to indicate if a room exists or will be created (added a text to the prefab)
remove 'GraphView'
andybak
commented
Oct 8, 2024
andybak
commented
Oct 8, 2024
|
|
||
| Share the room number with your sketch collaborators | ||
| to join ' | ||
| m_text: You have successfully joined the room! Share the room number with your |
There was a problem hiding this comment.
Be aware we need to handle localization for all text. Even if we only have an English translation for now - the components and code should support localization.
andybak
commented
Oct 8, 2024
| do | ||
| { | ||
| roomName = GenerateRandomRoomName(); | ||
| } while (MultiplayerManager.m_Instance.DoesRoomNameExist(roomName)); |
There was a problem hiding this comment.
Should we have a failsafe? An infinite loop might creep in because of a bug elsewhere. I never trust while loops without a guaranteed exit condition!
…open-brush into multiplayer/ui
This change set introduces event-driven handling for multiplayer disconnections and ensures that the MultiplayerPanel properly updates its UI when a disconnection occurs.
Add Leave Room button Add Leave Room Global Command
- Reducing payload per Stroke Chunk from 128 control points to 10 control points - Adding a single point where the payload can be edited called NetworkingConstants this is then used both in PhotonStructs.cs and PhotonManager.cs
mikeage
reviewed
Oct 15, 2024
| @@ -352,6 +352,7 @@ jobs: | |||
| with: | |||
| token: ${{ env.PHOTON_PAT }} | |||
| repository: icosa-mirror/photon-fusion | |||
| ref: v1.1.10 | |||
There was a problem hiding this comment.
Without this, it will take the latest. We probably should pin it, though, so this is a good change.
aligning the collider
Rebake attempt
1- Adding blank commands to avoid Unrecognized command Error
Multiplayer Panel 1 - Handle the Case When MultiplayerManager.m_Instance is null 2 - Avoid Accessing MultiplayerManager.m_Instance in Field Initializers
handle the removal of the player rig to ensure proper Clean-up
removing UnityEditor.Localization.Platform.Android
pass pre-commit
Adding this to solve the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.