Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential with older version of Eigen #579

Merged
merged 3 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
<a href="https://github.com/astral-sh/ruff"><img alt="ruff" src="https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json"></a>
</p>

[FCL](https://github.com/flexible-collision-library/fcl) was forked in 2015.
[FCL](https://github.com/flexible-collision-library/fcl) was forked in 2015.
Since then, a large part of the code has been rewritten or removed (for the unused and untested part).
The broad phase was reintroduced by [Justin Carpentier](https://github.com/jcarpent) in 2022 based on the FCL version 0.7.0.

If you use **HPP-FCL** in your projects and research papers, we would appreciate it if you'd [cite it](https://raw.githubusercontent.com/humanoid-path-planner/hpp-fcl/devel/CITATION.bib).
If you use **HPP-FCL** in your projects and research papers, we would appreciate it if you'd [cite it](https://raw.githubusercontent.com/humanoid-path-planner/hpp-fcl/devel/CITATION.bib).

## New features

Expand All @@ -27,7 +27,7 @@ Compared to the original [FCL](https://github.com/flexible-collision-library/fcl
- the implementation of Python bindings for easy code prototyping
- the support of new geometries such as height fields, capsules, ellipsoids, etc.
- enhance reliability with the fix of a myriad of bugs
- efficient computation of **contact points** and **contact patches** between objects
- efficient computation of **contact points** and **contact patches** between objects
- full support of object serialization via Boost.Serialization

This project is now used in many robotics frameworks such as [Pinocchio](https://github.com/stack-of-tasks/pinocchio), an open-source software that implements efficient and versatile rigid body dynamics algorithms, the [Humanoid Path Planner](https://humanoid-path-planner.github.io/hpp-doc), an open-source software for Motion and Manipulation Planning. **HPP-FCL** has also been recently used to develop [Simple](https://github.com/Simple-Robotics/Simple), a new (differentiable) and efficient simulator for robotics and beyond.
Expand Down
2 changes: 1 addition & 1 deletion include/hpp/fcl/contact_patch/contact_patch_solver.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void ContactPatchSolver::computePatch(const ShapeType1& s1,
}

// `eps` is be used to check strict positivity of determinants.
static constexpr FCL_REAL eps = Eigen::NumTraits<FCL_REAL>::dummy_precision();
const FCL_REAL eps = Eigen::NumTraits<FCL_REAL>::dummy_precision();
using Polygon = SupportSet::Polygon;

if ((this->support_set_shape1.size() == 2) &&
Expand Down
3 changes: 2 additions & 1 deletion include/hpp/fcl/fwd.hh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Software License Agreement (BSD License)
//
// Copyright (c) 2014, CNRS-LAAS
// Copyright (c) 2022, Inria
// Copyright (c) 2022-2024, Inria
// Author: Florent Lamiraux
//
// All rights reserved.
Expand Down Expand Up @@ -38,6 +38,7 @@
#ifndef HPP_FCL_FWD_HH
#define HPP_FCL_FWD_HH

#include <cassert>
#include <memory>
#include <sstream>
#include <stdexcept>
Expand Down
Loading