-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xmpp async #6640
Merged
Merged
Xmpp async #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
to-do
label
Oct 9, 2018
frenck
added
Hacktoberfest
An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
new-feature
This PR adds documentation for a new Home Assistant feature to an existing integration
ready-for-review
This PR needs to be reviewed
next
This PR goes into the next branch
has-parent
This PR has a parent PR in a other repo
in-progress
This PR/Issue is currently being worked on
and removed
to-do
ready-for-review
This PR needs to be reviewed
labels
Oct 9, 2018
fabaff
previously approved these changes
Oct 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
fabaff
approved these changes
Oct 13, 2018
@fabaff this will be in 0.81, won't it? so the version should be 0.81. |
Indeed, thanks. |
I will fix it after merging while updating the configuration section. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Hacktoberfest
An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
has-parent
This PR has a parent PR in a other repo
new-feature
This PR adds documentation for a new Home Assistant feature to an existing integration
next
This PR goes into the next branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
xmpp async support with new lib.
also:
resource
option for JIDPull request in home-assistant (if applicable): home-assistant/core#17283
Checklist:
next
is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent
.