-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XMPP async #17283
XMPP async #17283
Conversation
will try slixmpp instead of aioxmpp reasons: echo bot example of aioxmpp had blocking behavior (slixmpp echo bot works fine) closer API to sleekxmpp less dependencies than aioxmpp
the joinMUC method changed from sleekxmpp to slixmpp added debug messages better name for cleanup callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
I would highly appreciate also having httupuload integrated for xmpp notify ... Currently I use a cli command with But slixmpp also has build in httupuload functionality. I know not really very much people use xmpp but I think it's worth to get the best out of it . Furthermore I was thinking about a xmpp bit to interact with Hass ...well only ideas but httupuload would be great |
@thundergreen, I think that we should keep this PR limited to the migration to |
Why not just pimp this component to a next upper level? Would be nice to modernize this component ..like this it's an alternative to telegram and co, slixmpp offers this so why not using it? In terms of privacy and what this project aims to provide I think it's also time to give users with high privacy level a way to use a complete notifications platforms Without the need to build their very own custom platforms and services |
@thundergreen one PR per feature. |
@thundergreen I'd like to focus on the task at hand in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
Description:
Move notify.XMPP from sleekxmpp to slixmpp to allow async functionality.
resource
config option: lets users define the resource part of the sender address. see example below.Related issue (if applicable): fixes #17005
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6640
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: