refactor: remove old token metadata processor #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## nakamoto #1747 +/- ##
===========================================
Coverage ? 71.28%
===========================================
Files ? 86
Lines ? 11453
Branches ? 2470
===========================================
Hits ? 8164
Misses ? 3139
Partials ? 150 |
|
Vercel deployment URL: https://stacks-blockchain-7h5xjkqyt-blockstack.vercel.app 🚀 |
rafaelcr
changed the title
zone117x
reviewed
Nov 9, 2023
zone117x
reviewed
Nov 9, 2023
zone117x
reviewed
Nov 9, 2023
rafaelcr
added a commit
that referenced
this pull request
Nov 13, 2023
* refactor: remove old processor, start fetching data from contract * refactor: remove old tests * fix: tests and lint * fix: use lru cache * chore: delete old tables * chore: fix comments [skip ci] * fix: env comment block [skip ci] * chore: avoid duplicate RPC lookups * fix: make an incremental migration to drop tables * fix: re-add metadata processing ENV flag --------- Co-authored-by: Matthew Little <[email protected]>
|
🎉 This PR is included in version 7.4.0-nakamoto.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
|
🎉 This PR is included in version 7.6.0-nakamoto.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the old FT/NFT token metadata processor. We already have the Token Metadata API live and all current traffic is being redirected there.
This change will optimize block ingestion times because the API will no longer need to analyze the ABI of all deployed contracts to determine if they deploy FTs or NFTs. Also, it will no longer need to maintain token queues and notify listeners when the queues are updated.
Rosetta
This change impacts Rosetta, because FT operations still need to be displayed in blocks and transactions with the proper
symbolanddecimals. To solve this, a FT metadata retrieval class is added that just queries the relevant contracts for this info before operations are displayed, keeping it in an in-memory LRU cache for quicker access in the future.