Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the old token metadata processor #1582

Closed
rafaelcr opened this issue Mar 14, 2023 · 3 comments · Fixed by #1747
Closed

remove the old token metadata processor #1582

rafaelcr opened this issue Mar 14, 2023 · 3 comments · Fixed by #1747
Assignees
Labels
Milestone

Comments

@rafaelcr
Copy link
Collaborator

now that we have the Token Metadata API in place and that we are redirecting all FT metadata endpoints to it, we should get rid of the token metadata processor completely

@rafaelcr rafaelcr added the good first issue Good for newcomers label Mar 14, 2023
@rafaelcr
Copy link
Collaborator Author

we should, however, make sure we do not disrupt Rosetta's functionality when returning token operations (symbol, decimals, etc.)

@rafaelcr
Copy link
Collaborator Author

For Rosetta, we could fetch token contract decimals and symbols using read-only contract calls that follow SIP-010 (get-decimals, get-symbol) and use an in-memory cache for performance optimization

@smcclellan smcclellan added this to the Q2-2023 milestone May 25, 2023
@smcclellan smcclellan modified the milestones: Q2-2023, Q3-2023 Jul 11, 2023
@smcclellan
Copy link
Contributor

@rafaelcr Given that we can't get rid of this processor completely, is this still worth doing?

@smcclellan smcclellan assigned csgui and rafaelcr and unassigned csgui Jul 26, 2023
@rafaelcr rafaelcr self-assigned this Nov 8, 2023
@rafaelcr rafaelcr added nakamoto and removed icebox labels Nov 8, 2023
@rafaelcr rafaelcr linked a pull request Nov 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants