Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamicTable with all DataChunkIterator columns bug #953

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Sep 1, 2023

Fix #952

Raise error in DynamicTable init if all columns are specified via AbstractDataChunkIterator but no id's are set

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

…fied via AbstractDataChunkIterator but no id's are set
@oruebel oruebel changed the title Fix DynamicTable with all DataChunkIterator columns bug Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (e801d9e) 88.44% compared to head (682b050) 88.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #953      +/-   ##
==========================================
+ Coverage   88.44%   88.47%   +0.02%     
==========================================
  Files          45       45              
  Lines        9346     9350       +4     
  Branches     2662     2663       +1     
==========================================
+ Hits         8266     8272       +6     
+ Misses        762      761       -1     
+ Partials      318      317       -1     
Files Changed Coverage Δ
src/hdmf/common/table.py 85.82% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel requested a review from rly September 1, 2023 07:22
@CodyCBakerPhD
Copy link
Contributor

Perfect, erroring out as early as the creation of the table itself.

Very responsive, this satisfies my request, thanks!

@oruebel oruebel merged commit 9fe3f9d into dev Sep 1, 2023
26 checks passed
@oruebel oruebel deleted the fix/all_iterator_cols_in_table branch September 1, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Data of VectorData wrapped in DataChunkIterator produces roundtrip error on read
2 participants