Configure Sentry Replay #1232
Configure Sentry Replay #1232
Conversation
github-actions
bot
added
area/apps > hash*
This reverts commit 9f4d415.
| @@ -49,6 +53,10 @@ module.exports = withSentryConfig( | |||
| eslint: { ignoreDuringBuilds: true }, | |||
| typescript: { ignoreBuildErrors: true }, | |||
|
|
|||
| sentry: { | |||
| autoInstrumentServerFunctions: false, | |||
There was a problem hiding this comment.
| @@ -34,6 +34,10 @@ process.env.NEXT_PUBLIC_BLOCK_BASED_ENTITY_EDITOR = | |||
| // This allows the frontend to generate the graph type IDs in the browser | |||
| process.env.NEXT_PUBLIC_FRONTEND_DOMAIN = process.env.FRONTEND_DOMAIN; | |||
|
|
|||
| process.env.NEXT_PUBLIC_SENTRY_DSN = process.env.SENTRY_DSN; | |||
There was a problem hiding this comment.
I had to bump Next.js from 12.2 to 12.3 for this to work.
Before the bump, NEXT_PUBLIC_SENTRY_DSN was equal to "undefined" instead of undefined (likely because of a Next.js bug).
This broke Playwright: https://github.com/hashintel/hash/actions/runs/3292255307/jobs/5427399664#step:8:20
| replaysSamplingRate > 0 && | ||
| replaysSamplingRate <= 1 && |
There was a problem hiding this comment.
It's nice to have guards on the bounds, and makes things self-documenting too.
But in practice with this integration you can pass a value that is higher or lower than 0.0 or 1.0. So it's possible to get away with as little as this if you wanted:
environment: VERCEL_ENV,
integrations:
replaysSamplingRate
? [new Replay(...)]
: [],
tracesSampleRate: 1.0,
There was a problem hiding this comment.
Makes sense, addressed in aba0eb9 🙂
| const replaysSamplingRate = Number.parseInt( | ||
| SENTRY_REPLAYS_SAMPLING_RATE ?? "0", | ||
| 10, | ||
| ); |
There was a problem hiding this comment.
You might want to use Number.parseFloat here instead of Number.parseInt.
The allowed range is 0.0 <= replaysSamplingRate <= 1.0. Parsing to int means you'll endup with either 0 or 1, no values in between.
There was a problem hiding this comment.
Many thanks for catching this typo @ryan953! I replaced parseInt with parseFloat 👍
|
This pull request introduces 1 alert when merging ff54033 into c317591 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6b3c136 into 9852e3f - view on LGTM.com new alerts:
|
vilkinsons
added
type/eng > frontend
🌟 What is the purpose of this PR?
This PR updates Sentry and introduces @sentry/replay. The setup has been generally aligned with blockprotocol/blockprotocol.
🔗 Related links
@sentry/nextjsto7.16.0blockprotocol/blockprotocol#694🚫 Blocked by
🔍 What does this change?
next.config.jscontains several statements likeprocess.env.NEXT_PUBLIC_X = process.env.X. This simplifies infrastructure setup as it makes it easier to use env variables outside Next.js. The PR follows this principle forSENTRY_REPLAYS_SAMPLING_RATE.NEXT_PUBLIC_SENTRY_DSNhas been renamed toSENTRY_DSNtoo and new variables are created on Vercel accordingly.📜 Does this require a change to the docs?
No
🐾 Next steps
Check
🛡 What tests cover this?
❓ How to test this?