This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
bug: Prevent calling isInternal when not in the browser #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Oct 20, 2022
billyvg
changed the title
size-limit report 📦
|
Closed
|
Thanks for fixing this! Happy to test a new release in hashintel/hash#1232 |
|
@kachkaev Published |
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 23, 2022
…ntry-replay#253) The only method that could really be called a) in a node env b) during setup is `captureInternalException` which calls down to `isInternal`. So we need to make sure that `isInternal` is only accessing the `window` object if it exists. `lodash.debounce` is also called, but that's isomorphic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only method that could really be called a) in a node env b) during setup is
captureInternalExceptionwhich calls down toisInternal.So we need to make sure that
isInternalis only accessing thewindowobject if it exists.lodash.debounceis also called, but that's isomorphic.