Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml upon empty volumeMounts or volumes #855

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix yaml upon empty volumeMounts or volumes #855

wants to merge 5 commits into from

Commits on Mar 21, 2023

  1. Fix yaml upon empty volumeMounts or volumes 

    Today it create illegal yaml with undefined volumeMounts and volumes yielding these messages from kubeval:
WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.containers.0.volumeMounts: Invalid type. Expected: array, given: null
WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.volumes: Invalid type. Expected: array, given: null

Instead; insert empty lists.
    @thoraage
    thoraage authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ac8e2f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Avoid setting items with empty lists; instead ommit item if no values

    @thoraage
    thoraage committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3eeba4a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Merge branch 'hashicorp:main' into main

    @thoraage
    thoraage authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3de93c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Make tests work on more platforms

    @thoraage
    thoraage committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    83d1ab9 View commit details
    Browse the repository at this point in the history

  2. Add test to check that volumes and volumeMounts fields are not added … 

    …if empty
    @thoraage
    thoraage committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7ec65b2 View commit details
    Browse the repository at this point in the history