Fix yaml upon empty volumeMounts or volumes

[thoraage]

Today it create illegal yaml with undefined volumeMounts and volumes yielding these messages from kubeval: WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.containers.0.volumeMounts: Invalid type. Expected: array, given: null WARN - stdin contains an invalid Pod (vault.helm-vault-server-test) - spec.volumes: Invalid type. Expected: array, given: null

Instead; insert empty lists.

[hashicorp-cla]

All committers have signed the CLA.

[arve0]

Could also move the if statement one line up, to make it include the key, in example:

      {{- if .Values.server.volumeMounts }}
      volumeMounts:
          {{- toYaml .Values.server.volumeMounts | nindent 8}}
      {{- end }}

[thoraage]

Changed it now (better late than never)

[tvoran]

I think @arve0's suggestion makes sense, and it would also be good to add a test to test/unit/server-test.bats to check that the rendering for empty volumes is correct.

[tvoran]

Thanks! I think the only thing missing here is a test in test/unit/server-test.bats to verify that volumeMounts and volumes are not rendered when server.volumeMounts and server.volumes are not set.

[thoraage]

Added some tests.... a long time after