Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elife edits after review #21

Merged
merged 9 commits into from
Feb 13, 2024
Merged

elife edits after review #21

merged 9 commits into from
Feb 13, 2024

Conversation

nrosed
Copy link
Collaborator

@nrosed nrosed commented Feb 12, 2024

In this PR are the text/figure/table edits after reviewing the eLife reviews. There is a Google Doc that contains detailed feedback to each of the reviewers.

Biggest changes:

  • more contextualization in the discussion
  • better description of why certain method choices were made
  • male/female --> man/woman
  • new Supp. Table 5
  • removal of Supp figure 1 panels b and c. Panel a remains
  • using the full probability distribution of the name origin predictions instead of a hard assignment
  • Panel letters in the figure descriptions are now lowercase and bold.

@nrosed nrosed requested a review from cgreene February 12, 2024 18:57
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to be careful around ethnicity.

README.md Outdated Show resolved Hide resolved
content/02.introduction.md Outdated Show resolved Hide resolved
content/02.introduction.md Outdated Show resolved Hide resolved
content/04.results.md Outdated Show resolved Hide resolved
content/04.results.md Outdated Show resolved Hide resolved
content/05.discussion.md Outdated Show resolved Hide resolved
content/05.discussion.md Outdated Show resolved Hide resolved
content/05.discussion.md Outdated Show resolved Hide resolved
@nrosed nrosed merged commit 1107107 into greenelab:main Feb 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants