Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass correct results to TraceBatchFinishFunc #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass correct results to TraceBatchFinishFunc #72

wants to merge 1 commit into from
+40 −1

Commits on Mar 30, 2021

  1. Pass correct results to TraceBatchFinishFunc 

    The slice of *Result objects passed to TraceBatchFinishFunc was always
empty. By moving the `defer finish(items)` down below where items is
assigned the results of the batch function, tracers are passed the
actual results.

Fixes graph-gophers#63.
    @mjq
    mjq authored and Matt Quinn committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d659c93 View commit details
    Browse the repository at this point in the history