Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct results to TraceBatchFinishFunc #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjq
Copy link
Contributor

@mjq mjq commented Mar 29, 2021

Hi! I ran into #63 while using this library, so I took a pass at fixing it. Happy to make updates if you have any suggestions or concerns re: style or substance 😄 Thanks!

The slice of *Result objects passed to TraceBatchFinishFunc was always
empty. By moving the `defer finish(items)` down below where items is
assigned the results of the batch function, tracers are passed the
actual results.

Fixes graph-gophers#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant